Expose preferred language in member admin (#746)

Add a method to return the language name, or a warning for an invalid language code. --------- Co-authored-by: Rob Galanakis <[email protected]>
lithictech · Dec 3, 2024 · b230e68 · b230e68
1 parent 60bead2
commit b230e68
Show file tree

Hide file tree

Showing 5 changed files with 27 additions and 0 deletions.
diff --git a/adminapp/src/pages/MemberDetailPage.jsx b/adminapp/src/pages/MemberDetailPage.jsx
@@ -106,6 +106,10 @@ export default function MemberDetailPage() {
             <DetailGrid
               title="Other Information"
               properties={[
+                {
+                  label: "Preferred Language",
+                  value: model.preferences.preferredLanguageName,
+                },
                 { label: "Timezone", value: model.timezone },
                 { label: "Created At", value: dayjs(model.createdAt) },
                 {

diff --git a/lib/suma/admin_api/members.rb b/lib/suma/admin_api/members.rb
@@ -58,6 +58,7 @@ class PreferencesSubscriptionEntity < BaseEntity
   class PreferencesEntity < BaseEntity
     expose :public_url
     expose :subscriptions, with: PreferencesSubscriptionEntity
+    expose :preferred_language_name
   end
 
   class DetailedMemberEntity < MemberEntity

diff --git a/lib/suma/message/preferences.rb b/lib/suma/message/preferences.rb
@@ -57,6 +57,12 @@ def subscriptions
 
   def public_url = "#{Suma.app_url}/preferences-public?token=#{self.access_token}"
 
+  def preferred_language_name
+    return Suma::I18n::SUPPORTED_LOCALES.fetch(self.preferred_language).language
+  rescue KeyError
+    return "Invalid (#{self.preferred_language})"
+  end
+
   def validate
     super
     self.validates_includes Suma::I18n.enabled_locale_codes, :preferred_language

diff --git a/spec/suma/admin_api/members_spec.rb b/spec/suma/admin_api/members_spec.rb
@@ -124,12 +124,14 @@ def make_item(i)
       cash_ledger = Suma::Fixtures.ledger.member(admin).category(:cash).create
       charge1 = Suma::Fixtures.charge(member: admin).create
       charge1.add_book_transaction(Suma::Fixtures.book_transaction.from(cash_ledger).create)
+      admin.preferences!.update(preferred_language: "es")
 
       get "/v1/members/#{admin.id}"
 
       expect(last_response).to have_status(200)
       expect(last_response).to have_json_body.that_includes(
         sessions: contain_exactly(include(:ip_lookup_link)),
+        preferences: include(preferred_language_name: "Spanish"),
       )
     end
   end

diff --git a/spec/suma/message/preferences_spec.rb b/spec/suma/message/preferences_spec.rb
@@ -20,4 +20,18 @@
     deliveries = Suma::Fixtures.member.create.message_preferences!.update(preferred_language: "fr").dispatch(msg)
     expect(deliveries).to contain_exactly(have_attributes(template: "specs/localized", template_language: "fr"))
   end
+
+  describe "preferred_language_name" do
+    it "returns the language name" do
+      pref = Suma::Fixtures.member.create.message_preferences!
+      pref.preferred_language = "es"
+      expect(pref).to have_attributes(preferred_language_name: "Spanish")
+    end
+
+    it "uses a clear value if the message is set to an invalid locale" do
+      pref = Suma::Fixtures.member.create.message_preferences!
+      pref.preferred_language = "zz"
+      expect(pref).to have_attributes(preferred_language_name: "Invalid (zz)")
+    end
+  end
 end