Update Twilio verification only when transport_message_id is present (

#703)

Adds a condition to check if a reset code message deliveries' transport_message_id exists. Otherwise we get an error as per #698

lib/suma/async/reset_code_update_twilio.rb

@@ -24,6 +24,8 @@ def update_verification(code, status)
       md &&
         # email codes aren't using twilio verify, at least not yet (and probably never)
         md.transport_type == "sms" &&
+        # deliveries can potentially be aborted therefore a having nil message id
+        md.transport_message_id &&
         # We can send verifications using alternative templates; only the verification template uses
         # the 'send via twilio verify' logic in SmsTransport, so we only update twilio when we use that template.
         Suma::Message::SmsTransport.verification_delivery?(md)

spec/suma/async/jobs_spec.rb

@@ -182,13 +182,17 @@
     let(:member) { Suma::Fixtures.member(phone: "12223334444").create }
     let(:fac) { Suma::Fixtures.reset_code(member:).sms }
 
-    it "noops if the code has no delivery or has an invalid message id" do
+    it "noops if the code has no delivery, has an invalid message id or the delivery was aborted" do
       no_delivery = fac.create
       bad_msg_id = fac.create
       bad_msg_id.update(message_delivery: Suma::Fixtures.message_delivery.create(transport_message_id: "MSGID"))
+      template = Suma::Message::SmsTransport.verification_template
+      message_delivery = Suma::Fixtures.message_delivery.via("sms").create(template:, transport_message_id: nil)
+      nil_msg_id = fac.create(message_delivery:)
       expect do
         no_delivery.expire!
         bad_msg_id.expire!
+        nil_msg_id.expire!
       end.to perform_async_job(Suma::Async::ResetCodeUpdateTwilio)
     end