-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAT-16200 DevOps :: Support Docker like Liquibase Command Line #268
Draft
jandroav
wants to merge
9
commits into
main
Choose a base branch
from
DAT-16200
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: update Dockerfile.alpine WORKDIR to /liquibase/changelog for consistency
feat: add changelog.sql for test environment feat: add mssql-jdbc-8.2.2.jre11.jar driver for test environment feat: add example-changelog.xml for test environment feat: add liquibase-redshift-4.25.0.jar extension for test environment feat: add liquibase-mssql.properties for test environment feat: add liquibase.properties for test environment feat: add liquibase_command.sh script for test environment feat: add liquibase_update.sh script for test environment The above changes were made to add necessary files and configurations for the test environment. These files include a Dockerfile for building a test environment, a changelog.sql file for defining database schema changes, a mssql-jdbc-8.2.2.jre11.jar driver for connecting to the MSSQL database, an example-changelog.xml file for demonstrating how to define database changes using Liquibase, a liquibase-redshift-4.25.0.jar extension for supporting Redshift databases, a liquibase-mssql.properties file for configuring Liquibase to connect to the MSSQL database, a liquibase.properties file for configuring Liquibase with target and source database information, a liquibase_command.sh script for executing Liquibase tasks, and a liquibase_update.sh script for applying changes to the database. These additions are necessary to set up and manage the test environment effectively.
The .DS_Store file was deleted as it is an unnecessary file that is automatically generated by macOS. It is not needed for the project and can be safely removed.
@jandroav are the binaries for driver and extension expected here? |
The following files were removed: - `.github/test/Dockerfile`: Removed Dockerfile used for Liquibase testing. - `.github/test/drivers/mssql-jdbc-8.2.2.jre11.jar`: Removed JDBC driver for Microsoft SQL Server used in Liquibase testing. - `.github/test/example-changelog.xml`: Removed example changelog file used in Liquibase testing. - `.github/test/extensions/liquibase-redshift-4.25.0.jar`: Removed Liquibase extension for Amazon Redshift used in Liquibase testing. - `.github/test/liquibase.properties`: Removed Liquibase properties file used in Liquibase testing. - `.github/test/scripts/liquibase_command.sh`: Removed shell script for Liquibase command used in Liquibase testing. - `.github/test/scripts/liquibase_update.sh`: Removed shell script for Liquibase update command used in Liquibase testing. These files were no longer needed and were deleted to clean up the repository.
no @jnewton03 , I just deleted all non-needed resources to test it. |
jnewton03
approved these changes
Dec 27, 2023
…root to improve security and prevent potential privilege escalation
…liquibase command to remove the leading slash for consistency
… file structure The file paths in the example commands were incorrect and did not match the actual file structure. This commit fixes the file paths in the example commands to accurately reflect the file structure.
…riable to fix incorrect file path
@jnewton03 I modified the README.md file and updated the tests |
converting to draft to potentially be used at a later date |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.