Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerized #2

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Dockerized #2

wants to merge 17 commits into from

Conversation

manicprone
Copy link

@manicprone manicprone commented Oct 27, 2021

This PR includes:

  • Dockerization of the API server (with useful npm scripts for local dev).
  • A GitHub action for build/publish of the Docker image (currently not using a version cycle).
  • A systemDefaults.js to manage default values that are supported.
  • A /status GET endpoint for a simple health check (which requests the electrs /blocks/tip/height endpoint)
  • A pre-commit hook to ensure linting passes before commit.

The main point of this PR is to make my work visible (not necessarily to merge into the trunk branch). But, it can be merged in safely. I am currently using this with the AWS setup.

Future items:

  • Update the CI/CD pipeline to build/push on version updates of the code. Currently performs this action whenever pushed to a branch named: dockerized.
  • Update README to include relevant info on docker usage.

@manicprone manicprone requested a review from harshjv October 27, 2021 20:33
@manicprone manicprone requested a review from devaraj-s December 3, 2021 17:47
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Dec 3, 2021
@tiero tiero mentioned this pull request Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔍 Ready for Review Pull Request is not reviewed yet size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants