Allow disabling IPv6 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am a bot, here is the pushed image/manifest for this PR:
|
|
this PR insults me as an IPv6 cult member, but overall this drop-in looks like it covers many of the deficiencies seen in the upstream project. Glad to see this project is getting the attention it deserves! |
drizuid
approved these changes
Apr 15, 2024
|
I am a bot, here is the pushed image/manifest for this PR:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Allow disabling IPv6 for legacy hosts that can't support it. This will stop nginx attempting to bind to an IPv6 interface that doesn't exist. Note that even containers that are connected to an IPv4-only docker network will have an IPv6 interface internally unless it's been explicitly disabled in the host network stack.
Benefits of this PR and context:
This should allow us to provide a complete drop-in alternative for the original container where users are running into issues such as Tecnativa/docker-socket-proxy#122 or require regular package updates (It is not currently automatically rebuilt when upstream images or packages are updated).
How Has This Been Tested?
Source / References: