Fix several issues noted in #343 and #347 #353
Conversation
Signed-off-by: Henry Cox <[email protected]>
|
@henry2cox if #347 is fixed here, we can drop line… lcov/.github/workflows/run_test_suite.yml Line 68 in e4b3129 …here and have the CI confirm (to some extent) that the fix (is complete and) works as expected. |
ah..right. Oversight. |
@henry2cox I believe there are two conflicting schools about it: school A (including me) would say the branch is yours and yours only you can force push into it until it's merged and school B (including CPython) would ask to only add new commits on top for all changes you make during review. |
| @@ -65,7 +65,6 @@ jobs: | |||
|
|
|||
| sudo perl -MCPAN -e 'install(Memory::Process)' # no package in Ubuntu | |||
|
|
|||
There was a problem hiding this comment.
(just an idea: I think that blank line before could also be dropped)
|
@henry2cox the CI likes it 🎉 |
| @@ -62,10 +62,8 @@ jobs: | |||
|
|
|||
| sudo apt-get update | |||
| sudo apt-get install --no-install-recommends --yes -V "${ubuntu_packages[@]}" | |||
|
|
|||
There was a problem hiding this comment.
@henry2cox that's the wrong blank line now. My point was about the two consecutive blank lines below.
There was a problem hiding this comment.
@henry2cox looks just right now though 👍
…eir Coverage.py execuable. Default is retrieved from 'COVERAGE_COMMAND' environment variable, or is set to 'coverage' otherwise. See linux-test-project#347 Signed-off-by: Henry Cox <[email protected]>
See linux-test-project#343. Signed-off-by: Henry Cox <[email protected]>
Signed-off-by: Henry Cox <[email protected]>
|
@henry2cox my vote for merging but without squash-merge to keep the commit cutting intact on |
No description provided.