refactor(provider): refactor "ASYNC_DIRECT" callback signature

.github/workflows/ci.yml

@@ -45,10 +45,11 @@ jobs:
         run: |
           cargo binstall --no-confirm selene
           selene --config selene.toml ./lua
-      # - uses: stevearc/nvim-typecheck-action@v2
-      #   with:
-      #     path: lua
-      #     configpath: ".luarc.json"
+      - uses: stevearc/nvim-typecheck-action@v2
+        with:
+          nvim-version: v0.10.3
+          path: lua
+          configpath: ".luarc.json"
       - uses: stefanzweifel/git-auto-commit-action@v5
         if: ${{ github.ref != 'refs/heads/main' }}
         with:

lua/fzfx/cfg/_lsp_locations.lua

@@ -290,7 +290,8 @@
   local function impl(query, context, on_complete)
     local lsp_clients = lsp.get_clients({ bufnr = context.bufnr })
     if tbl.tbl_empty(lsp_clients) then
-      on_complete("no active lsp clients.")
+      log.echo(LogLevels.INFO, "no active lsp clients.")
+      on_complete(nil)
       return
     end
 
@@ -307,7 +308,7 @@
     end
     if not supported then
       log.echo(LogLevels.INFO, vim.inspect(opts.method) .. " not supported.")
-      on_complete(vim.inspect(opts.method) .. " not supported.")
+      on_complete(nil)
       return
     end
 
@@ -324,11 +325,11 @@
 
         if tbl.tbl_empty(results) then
           log.echo(LogLevels.INFO, "no lsp locations found.")
-          on_complete("no lsp locations found.")
+          on_complete(nil)
           return
         end
 
-        on_complete(nil, results)
+        on_complete(results)
       end
     )
 
@@ -644,7 +645,8 @@
   local function impl(query, context, on_complete)
     local lsp_clients = lsp.get_clients({ bufnr = context.bufnr })
     if tbl.tbl_empty(lsp_clients) then
-      on_complete("no active lsp clients.")
+      log.echo(LogLevels.INFO, "no active lsp clients.")
+      on_complete(nil)
       return
     end
     -- log.debug(
@@ -659,7 +661,8 @@
       end
     end
     if not supported then
-      on_complete(vim.inspect(opts.method) .. " not supported.")
+      log.echo(LogLevels.INFO, vim.inspect(opts.method) .. " not supported.")
+      on_complete(nil)
       return
     end
 
@@ -676,7 +679,8 @@
           M._process_prepare_call_hierarchy_response(response1 --[[@as table? ]])
 
         if prepared_item == nil then
-          on_complete("no lsp call hierarchy found.")
+          log.echo(LogLevels.INFO, "no lsp call hierarchy found.")
+          on_complete(nil)
           return
         end
 
@@ -692,11 +696,12 @@
             local results = M._process_call_hierarchy_response(response2 --[[@as table? ]], opts)
 
             if tbl.tbl_empty(results) then
-              on_complete("no lsp call hierarchy found.")
+              log.echo(LogLevels.INFO, "no lsp call hierarchy found.")
+              on_complete(nil)
               return
             end
 
-            on_complete(nil, results)
+            on_complete(results)
           end
         )
 

lua/fzfx/cfg/git_branches.lua

@@ -92,13 +92,15 @@
     async.void(function()
       local git_root_cmd = context.git_root_cmd
       if git_root_cmd:failed() then
-        on_complete("not in git repo.")
+        log.echo(LogLevels.INFO, "not in git repo.")
+        on_complete(nil)
         return
       end
 
       local git_current_branch_cmd = cmds.run_git_current_branch_async()
       if git_current_branch_cmd:failed() then
-        on_complete(table.concat(git_current_branch_cmd.stderr, " "))
+        log.echo(LogLevels.INFO, table.concat(git_current_branch_cmd.stderr, " "))
+        on_complete(nil)
         return
       end
 
@@ -107,7 +109,8 @@
 
       local git_branches_cmd = cmds.run_git_branches_async(remote_branch)
       if git_branches_cmd:failed() then
-        on_complete(table.concat(git_branches_cmd.stderr, " "))
+        log.echo(LogLevels.INFO, table.concat(git_branches_cmd.stderr, " "))
+        on_complete(nil)
         return
       end
 
@@ -117,7 +120,7 @@
         end
       end
 
-      on_complete(nil, results)
+      on_complete(results)
     end)()
   end
 

lua/fzfx/detail/general.lua

@@ -387,34 +387,16 @@
 --- @param query string?
 --- @param context fzfx.PipelineContext?
 function ProviderSwitch:_handle_async_direct(provider_config, query, context)
-  --- @param err1 string?
-  --- @param data1 string[]?
-  local function _on_complete(err1, data1)
-    log.debug(
-      string.format("|async done| data1:%s, err1:%s", vim.inspect(data1), vim.inspect(err1))
-    )
+  --- @param data1 string[]|nil
+  local function _on_complete(data1)
+    log.debug(string.format("|async done| data1:%s", vim.inspect(data1)))
     log.debug(string.format("|async done| donefile:%s", vim.inspect(self.donefile)))
 
     -- When data is ready, write it into `resultfile`.
-    if err1 then
+    if tbl.tbl_empty(data1) then
       fio.writefile(self.resultfile, "")
-      log.echo(LogLevels.INFO, err1)
-      -- log.err(
-      --   string.format(
-      --     "failed to complete pipeline %s (ASYNC_DIRECT provider %s)! query:%s, context:%s, error:%s",
-      --     vim.inspect(self.pipeline),
-      --     vim.inspect(provider_config),
-      --     vim.inspect(query),
-      --     vim.inspect(context),
-      --     vim.inspect(err1)
-      --   )
-      -- )
     else
-      if tbl.tbl_empty(data1) then
-        fio.writefile(self.resultfile, "")
-      else
-        fio.writelines(self.resultfile, data1 --[[@as string[] ]])
-      end
+      fio.writelines(self.resultfile, data1 --[[@as string[] ]])
     end
 
     -- Then notify provider it is ready.

lua/fzfx/schema.lua

@@ -14,7 +14,7 @@
 --- @alias fzfx.CommandStringProvider fzfx.PlainCommandStringProvider|fzfx.FunctionalCommandStringProvider
 --- @alias fzfx.CommandArrayProvider fzfx.PlainCommandArrayProvider|fzfx.FunctionalCommandArrayProvider
 --- @alias fzfx.DirectProvider fun(query:string?,context:fzfx.PipelineContext?):string[]?
---- @alias fzfx.AsyncDirectProviderOnComplete fun(err:string?,data:string[]?):nil
+--- @alias fzfx.AsyncDirectProviderOnComplete fun(data:string[]|nil):nil
 --- @alias fzfx.AsyncDirectProvider fun(query:string?,context:fzfx.PipelineContext?,on_complete:fzfx.AsyncDirectProviderOnComplete):nil
 --- @alias fzfx.Provider fzfx.CommandStringProvider|fzfx.CommandArrayProvider|fzfx.DirectProvider|fzfx.AsyncDirectProvider
 ---