Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: doPOSTRequestNoResponseBody Request Helper that doesn't Expecets Return Value #654

Merged

Conversation

zliang-akamai
Copy link
Member

📝 Description

This may simplify some request helper call to doPOSTRequest. Examples are included in files changed.

This is a proposal for discussion, feel free to suggest change or objection of merging it.

@zliang-akamai zliang-akamai marked this pull request as ready for review January 10, 2025 21:22
@zliang-akamai zliang-akamai requested a review from a team as a code owner January 10, 2025 21:22
@zliang-akamai zliang-akamai requested review from ykim-akamai and yec-akamai and removed request for a team January 10, 2025 21:22
@zliang-akamai zliang-akamai force-pushed the zhiwei/noresponsepostrequesthelper branch 3 times, most recently from 7677de7 to 8b242b3 Compare January 14, 2025 19:59
@zliang-akamai zliang-akamai requested review from lgarber-akamai, ezilber-akamai, a team and jriddle-linode and removed request for a team January 15, 2025 05:08
Copy link
Contributor

@ezilber-akamai ezilber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good addition! Definitely simplifies quite a few endpoint functions so I see no reason not to use this new helper.

Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea and nice work!

@yec-akamai yec-akamai merged commit fcf4b18 into linode:main Jan 15, 2025
10 checks passed
@yec-akamai yec-akamai added the improvement for improvements in existing functionality in the changelog. label Jan 15, 2025
@zliang-akamai zliang-akamai deleted the zhiwei/noresponsepostrequesthelper branch January 16, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement for improvements in existing functionality in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants