Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add advanced CodeQL and dependencies review workflows #640

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Add advanced CodeQL and dependencies review workflows #640

merged 1 commit into from
Dec 16, 2024

Conversation

zliang-akamai
Copy link
Member

📝 Description

This is to add workflows for:

  1. CodeQL scan for PRs from forks.
  2. Dependencies review for all PRs that change the list of dependencies.

@zliang-akamai zliang-akamai requested a review from a team as a code owner December 10, 2024 05:59
@zliang-akamai zliang-akamai requested review from ykim-akamai and ezilber-akamai and removed request for a team December 10, 2024 05:59
ezilber-akamai
ezilber-akamai reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@ezilber-akamai ezilber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Is there a good way to test these workflows out?

@zliang-akamai
Copy link
Member Author

Hi @ezilber-akamai, I think GitHub automatically runs the workflows inthis PR already:

image

ykim-akamai
ykim-akamai approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@zliang-akamai zliang-akamai merged commit 5fc5868 into main Dec 16, 2024
11 checks passed
@zliang-akamai zliang-akamai deleted the zhiwei/sec-workflows branch December 16, 2024 21:54
@zliang-akamai zliang-akamai added the repo-ci-improvement for improvements in the repository or CI workflow in the changelog. label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezilber-akamai ezilber-akamai ezilber-akamai approved these changes

@ykim-akamai ykim-akamai ykim-akamai approved these changes

Assignees
No one assigned
Labels
repo-ci-improvement for improvements in the repository or CI workflow in the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zliang-akamai @ykim-akamai @ezilber-akamai