Wire up zipkin stats receivers #4
Conversation
| KafkaZipkinTracer.create(config, NullStatsReceiver) | ||
| def mk(params: Stack.Params): KafkaTelemeter = { | ||
| val param.Stats(stats) = params[param.Stats] | ||
| val tracer = KafkaZipkinTracer.create(config, stats.scope("zipkin.kafka")) |
There was a problem hiding this comment.
i know we're nowhere near consistent about this, but let's call this "io.zipkin.kafka" to match the plugin name or even configID / topic if we think it's reasonable to run multiple telemeters to different topics
| HttpZipkinTracer.create(config, NullStatsReceiver) | ||
| def mk(params: Stack.Params): HttpTelemeter = { | ||
| val param.Stats(stats) = params[param.Stats] | ||
| val tracer = HttpZipkinTracer.create(config, stats.scope("zipkin.http")) |
|
Ok, I updated the stats prefixes, and that actually helped to determine that this branch is not working correctly. With the http tracer configured, here are all of the zipkin stats that show up in metrics.json: https://gist.github.com/klingerf/b63b33ad68dfe65278091abcb3f13e8b. The only new stat in that payload that appears as a result of this change is: Which is clearly incorrect. The rest of the stats in the payload appear to be happening automatically, and are not tied to the stats receiver that's used to initialize the tracers from this repo. As far as I understand it, this is where all of these stats appear to be coming from:
It would be great to disable autoloading for all of these tracers that are unused. And additionally, it would be good to fix the stats receiver issue in zipkin-finagle that's causing the malformed stats. In the meantime though, I don't think it makes sense to proceed with this change since we're already getting stats from the zipkin-finagle http tracer, and the scoping on those stats is not configurable from this repo, as far as I can tell. |
|
@klingerf should we close this PR then? |
|
@adleong Yeah, I think it makes sense to close this. Thanks for checking. |
Use the stats receiver provided by the stack when initializing the http and kafka tracers. Fixes #3.