-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shadow and slider #819
Draft
Cupnfish
wants to merge
33
commits into
linebender:main
Choose a base branch
from
Cupnfish:shadow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
shadow and slider #819
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
fcd5c9a
feat: add shadow support to SizedBox widget
snooowfire 5bdf026
test: add shadow rendering tests for SizedBox widget
snooowfire 0ab4800
fix: add missing shadow field and fix shadow rendering in SizedBox
snooowfire adf58c9
feat: Add shadow field to SizedBox constructors
snooowfire 1777255
feat: add corner radius support for shadows in SizedBox widget
snooowfire a48fdf4
feat: Add shadow support to SizedBox view with example
snooowfire 9ccd311
feat: Move shadow example from web to xilem/examples
snooowfire 15d3793
feat: add shadow example to Cargo.toml
snooowfire a6391ef
feat: add Slider widget with configurable range, colors and accessibi…
snooowfire 24ac807
fix: Add missing imports and implement widget methods in slider
snooowfire f57d801
feat: Implement child widget handling in Slider component
snooowfire 85b0eb5
fix: Add missing imports and update paths in slider.rs
snooowfire 773b091
fix: Add missing Affine import in Slider widget
snooowfire d7b6eed
feat: add Slider widget implementation to xilem
snooowfire 69135cd
refactor: enhance slider with range, color customization, and builder…
snooowfire c6a5e4e
refactor: align slider implementation with Xilem view patterns
snooowfire 3f56150
refactor: Move ViewCtx import to correct module in slider.rs
snooowfire a1e1fd7
refactor: align slider implementation with button's patterns and mess…
snooowfire 1807b81
refactor: Remove unused ViewCtx import in slider.rs
snooowfire 489d3ca
refactor: update slider's on_change callback to match button pattern
snooowfire d498251
refactor: Replace Box<dyn> with generic F for Slider's on_change call…
snooowfire 9fe10b1
refactor: Simplify Slider implementation by removing State and Action…
snooowfire ad07796
refactor: generalize slider function to accept State and Action types
snooowfire 01da463
refactor: make on_change a required parameter in slider constructor
snooowfire 5ebee47
refactor: simplify slider widget implementation and add tests
snooowfire 3610696
chore: remove shadow example from workspace
snooowfire 5382a19
feat: add SliderValueChanged action for slider widget
snooowfire abbc254
feat: add shadow support to SizedBox widget
snooowfire 43dae69
feat: add shadow example demonstrating shadow controls
snooowfire 9b359c7
feat: update SizedBox view to support shadow properties
snooowfire d130631
refactor: improve Slider view implementation
snooowfire af4fc84
Merge commit 'd130631' into shadow
snooowfire d92d36b
feat: enhance slider widget with new features and improvements
Cupnfish File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
/target | ||
.DS_Store | ||
*.diff |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you using the clipped version of the blurred rect? The
_in
version. The unclipped version is how I would expect it to look.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Oh... It already is using blurred_rounded_rect... Oops)