Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure command line arguments in Android and WASM #443

Merged
merged 5 commits into from
Mar 5, 2024

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Feb 16, 2024

Primarily, the two new environment variables are very useful:

  1. VELLO_STATIC_LOG allows configuring logging for Android (equivalent to RUST_LOG, but at compile time)
  2. VELLO_STATIC_ARGS allows configuring the command line arguments

For example,

VELLO_STATIC_LOG="with_winit=debug,vello::wgpu_engine=debug" VELLO_STATIC_ARGS="--test-scenes --scene 2 --use-cpu" cargo apk run -p with_winit --lib --release

would have debug level logging in with_winit and the wgpu_engine module, and start at the third test scene, using the CPU shaders

@waywardmonkeys
Copy link
Collaborator

Since this is adding a dependency on log, this might be a good time (in a separate issue?) to discuss using tracing instead ... There's an open issue about winit moving to tracing as well.

@DJMcNab
Copy link
Member Author

DJMcNab commented Feb 19, 2024

Possibly - we already depend on both in with_winit and with_bevy. In the main vello crate, I think we depend on log already, but not tracing directly.

@DJMcNab DJMcNab changed the title Experiment setups for android startup Allow configuring command line arguments in Android Feb 20, 2024
@DJMcNab DJMcNab marked this pull request as ready for review February 20, 2024 16:18
@DJMcNab DJMcNab force-pushed the android-startup branch 2 times, most recently from f999262 to 633efe9 Compare February 28, 2024 11:57
@DJMcNab DJMcNab requested a review from xorgy March 4, 2024 10:15
@xorgy
Copy link
Member

xorgy commented Mar 4, 2024

I like it.

DJMcNab added 5 commits March 5, 2024 08:39
Resolve the diagnostics issue for the `main` on Android
Allow storing vscode settings in a suitably named local file

Get the Android cache directory

Make the cache folder for Vello directly

Skip MSAA only on Android
Remove the cache directory finding

Remove instant usage
This seems to have regressed
@DJMcNab DJMcNab changed the title Allow configuring command line arguments in Android Configure command line arguments in Android and WASM Mar 5, 2024
@DJMcNab DJMcNab enabled auto-merge March 5, 2024 08:40
@DJMcNab DJMcNab added this pull request to the merge queue Mar 5, 2024
Merged via the queue into linebender:main with commit 0347b39 Mar 5, 2024
9 checks passed
@DJMcNab DJMcNab deleted the android-startup branch March 5, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants