Fix outdated links to tiny-skia #134
Conversation
It would seem that GitHub Pages don't automatically get redirected after a repository moves to a new owner.
All of the links changed here were still working thanks to redirects on GitHub's end. This change is just a clean-up. We don't touch links in the changelog in this change.
This updates the links to tiny-skia in the changelog. All of the links changed here were still working thanks to redirects on GitHub's end. This change is just a clean-up.
| @@ -6,7 +6,7 @@ edition = "2018" | |||
| description = "A tiny-skia Bezier path implementation" | |||
| documentation = "https://docs.rs/tiny-skia-path/" | |||
| readme = "README.md" | |||
| repository = "https://github.com/RazrFalcon/tiny-skia/tree/master/path" | |||
| repository = "https://github.com/linebender/tiny-skia/tree/master/path" | |||
There was a problem hiding this comment.
I think this should be:
| repository = "https://github.com/linebender/tiny-skia/tree/master/path" | |
| repository = "https://github.com/linebender/tiny-skia" |
The docs (https://doc.rust-lang.org/cargo/reference/manifest.html#the-repository-field) are a bit underspecified
There was a problem hiding this comment.
I'm not sure, either. But as is, the "Repository" link on https://crates.io/crates/tiny-skia-path is more useful IMO.
There was a problem hiding this comment.
Hmm, should this not at least have been changed to /main/?
Incidentally, the advantage of repository as documented is that it's the URL you'd use if you wanted to add a git dependency on the project.
A quick check:
- tracing uses the top-level repository
- serde uses the top-level repository
- Vello uses the top-level repository
- Naga uses the GitHub specific path
There was a problem hiding this comment.
Hmm, should this not at least have been changed to
/main/?
Probably, yeah. GitHub does redirect it, though, so it'll be just another cleanup.
I'll defer to actual Rust users on crate metadata, but I'm inclined to agree with you.
This updates all links to tiny-skia from RazrFalcon to linebender. The changes to links to GitHub Pages are necessary, as the current links are 404. All other changes are optional and only avoid relying on redirections.
This PR is split into three commits:
I'm unsure about updating the links that redirect, and very unsure about changing the changelog. We can drop any of those two commits if we want to.