Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added some more i18n strings for German and made some buttons and labels into LocalizedString in the process #134

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Connum
Copy link

@Connum Connum commented Aug 20, 2020

Although there is no locale switching functionality implemented yet, I was able to test this by using druid 0.6 locally via [patch.crates-io] and making get_locale() return "de-DE" instead of "en-US".

@Connum
Copy link
Author

Connum commented Aug 20, 2020

Sorry for the commit confusion... I tried to squash it, but it seems I only made matters worse, and for some reason I can't get it to work, it always addes another commit. Also, the bloat check fails and I can't see why.

@cmyr
Copy link
Member

cmyr commented Aug 22, 2020

hey, thanks for this! The correct locale may not be retrieved correctly on GTK, but it should work on mac and maybe windows?

Also don't worry about bloat check; there's an issue where it only works when the source branch is in this repository. 😒

Currently however, there's no way in druid for an app to provide their own localization resources, I don't think?? There are built-in localization strings for some elements in druid, so maybe you were seeing those when you changed your locale?

I think my inclination is to leave this PR open until I get the localization stuff working in druid, and then I can figure out the best way to integrate this.

@Connum
Copy link
Author

Connum commented Aug 22, 2020

I tried it and it displayed my newly added strings correctly as well! ☺️ As far as I can see, druid automatically loops over all the files in the i18n base dir for the specified language and tries to parse them? So I think I could have named the flt file differently. But we'll see, once it's supported officially.

@cmyr
Copy link
Member

cmyr commented Aug 22, 2020

ha, you're right, this will work as long as we're building from source, and running the application from the runebender directory. It's kind of an accident that it works. A lot of the strings you've included here are in the localization files in druid, and the idea is that at some point in the future when an app gets packaged up it will copy the localization files from your project, as well as the ones needed that are included in druid, and put those all in the appropriate place. That's not going to happen for a bit, though.

@davelab6
Copy link
Contributor

@cmyr this seems like something small and simple to merge :)

@cmyr cmyr added the blocked This task cannot be completed right now. label Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This task cannot be completed right now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants