Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image alpha channel is now an f32 #65

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

waywardmonkeys
Copy link
Contributor

@waywardmonkeys waywardmonkeys commented Nov 27, 2024

In the next release of Peniko, our alpha channels will all be f32 as we move to the new color code.

Also, new version of cargo-nextest fails when there are no tests and this crate has no tests, so don't fail.

@waywardmonkeys
Copy link
Contributor Author

This will make landing #63 easier.

@waywardmonkeys
Copy link
Contributor Author

It is worth noting that this field is ignored in Vello, I think.

@waywardmonkeys
Copy link
Contributor Author

It is worth noting that this field is ignored in Vello, I think.

This is linebender/vello#692

Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't thought deeply about using f32 instead, but I guess consistency with color makes sense.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
In the next release of Peniko, our alpha channels will all be `f32`
as we move to the new color code.

Also, new version of `cargo-nextest` fails when there are no tests
and this crate has no tests, so don't fail.
.github/workflows/ci.yml Show resolved Hide resolved
@waywardmonkeys waywardmonkeys added this pull request to the merge queue Nov 27, 2024
Merged via the queue into linebender:main with commit f582191 Nov 27, 2024
15 checks passed
@waywardmonkeys waywardmonkeys deleted the image-alpha-f32 branch November 27, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants