Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Div<f64> and Mul<f64> for Insets #384

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

liferooter
Copy link
Contributor

This can be useful, for example, for applying scaling factor to Insets.

@waywardmonkeys
Copy link
Contributor

@raphlinus Thoughts?

Copy link
Contributor

@raphlinus raphlinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, these are useful methods to have, mathematically sound, and the obvious implementation does what you'd expect. Thanks!

@waywardmonkeys
Copy link
Contributor

@liferooter Hello! Would you be able to rebase this forward and update the PR so that CI runs again with the current configuration and then I'll merge this. Thanks!

@liferooter
Copy link
Contributor Author

@liferooter Hello! Would you be able to rebase this forward and update the PR

Done

@waywardmonkeys
Copy link
Contributor

@liferooter Thank you!

@waywardmonkeys waywardmonkeys added this pull request to the merge queue Dec 7, 2024
Merged via the queue into linebender:main with commit ebb8553 Dec 7, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants