Add more docs. #366
Add more docs. #366
Conversation
| /// | ||
| /// Equivalent to `self * Affine::rotate_about(th)` | ||
| /// | ||
| /// [rotation]: Affine::rotate_about | ||
| #[inline] | ||
| #[must_use] | ||
| pub fn pre_rotate_about(self, th: f64, center: Point) -> Self { | ||
| Affine::rotate_about(th, center) * self |
There was a problem hiding this comment.
I think this needs to be:
| Affine::rotate_about(th, center) * self | |
| self * Affine::rotate_about(th, center) |
Although that might be for a different PR
There was a problem hiding this comment.
This needs to be a separate PR. I think the core is wrong here, not the doc comment.
There was a problem hiding this comment.
What I meant was that I too think the code is wrong and this is a docs patch, so I'd rather handle it separately. :)
| /// with `width` and `height` [rounded towards] zero to the nearest integer, | ||
| /// unless they are already an integer. |
There was a problem hiding this comment.
An optional suggestion - I'd slightly prefer this to be something like:
| /// with `width` and `height` [rounded towards] zero to the nearest integer, | |
| /// unless they are already an integer. | |
| /// with `width` and `height` [truncated][rounded towards] to their integer part. | |
| /// This effectively rounds them to the nearest integer towards zero. |
I don't think "rounds towards zero to the nearest integer" flows very well, because in my mind "towards zero" is a modifier on the entire "rounds to the nearest integer".
There was a problem hiding this comment.
I'd rather this one be addressed separately as this sort of text is in more than one place.
waywardmonkeys
force-pushed
the
more-docs
branch
from
d4054f3 to
02b73a9
Compare
No description provided.