Split VelloAsset into VelloSvg and VelloLottie #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simbleau
changed the title
seabassjh
approved these changes
Feb 6, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Failed merging due to bevyengine/bevy#17699, which is unrelated to the PR. I created a new PR to unblock merging: #103 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
Our pipeline in #90 is unable to merge due to bevyengine/bevy#17699 This PR fixes the issue with a workaround. Stage the Cargo.lock, and fix the transitive dependency on getrandom. Dually Closes #91 and unblocks #90
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds upon #87. Merge that first.
Closes #89.