Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize pseudobulk analysis functions #297

Closed
wants to merge 13 commits into from
Closed

Reorganize pseudobulk analysis functions #297

wants to merge 13 commits into from

Conversation

yihming
Copy link
Member

@yihming yihming commented May 28, 2024

Modify pseudobulk function:

  • Rename sample to groupby
  • Rename cluster to condition
  • Return a MultimodalData object, and don't write to the original data object
  • Enforce non-numeric attributes set in attrs to be categorical in the pseudobulk data object

Modify deseq2 function:

  • It takes 2 backend subfunctions run_pydeseq2 and run_rdeseq2. Default is run_pydeseq2
  • Add compute_all parameter to decide if applying DE analysis to all count matrices

Renam fgsea function to gsea, and modify:

  • Add method parameter: default is "blitzgea"; alternatively support "fgsea"
  • Set min_size to 5, and max_size to 4000
  • For blitzGSEA, center by default is False

Compatible with matplotlib v3.9+:

  • Change legend.legendHandles to legend.legend_handles, as v3.9+ removes legendHandles attribute.

Improve calc_dendrogram function:

  • Simplify logic on rep by using update_rep and X_from_rep utility functions

@yihming yihming requested a review from bli25 May 28, 2024 01:06
@yihming yihming changed the title Improve pseudobulk function Reorganize pseudobulk analysis functions May 28, 2024
@yihming yihming closed this Jun 1, 2024
@yihming yihming reopened this Jun 1, 2024
@yihming yihming marked this pull request as draft June 1, 2024 06:30
@yihming yihming removed the request for review from bli25 June 1, 2024 06:30
@yihming yihming closed this Jun 3, 2024
@yihming yihming deleted the yiming branch June 11, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant