Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] chore: remove backup #289

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

alexislefebvre
Copy link
Collaborator

@alexislefebvre alexislefebvre added this to the 3.x milestone Mar 10, 2024
@alexislefebvre alexislefebvre changed the title chore: remove backup [3.x] chore: remove backup Mar 10, 2024
@alexislefebvre alexislefebvre force-pushed the chore-remove-backup-3.x branch 3 times, most recently from 3b9e75d to 28a9703 Compare March 10, 2024 23:31
@alexislefebvre alexislefebvre self-assigned this Mar 10, 2024
@alexislefebvre alexislefebvre marked this pull request as draft March 10, 2024 23:58
@alexislefebvre alexislefebvre force-pushed the chore-remove-backup-3.x branch 3 times, most recently from 7d3874b to 45feee5 Compare March 11, 2024 12:42
@alexislefebvre alexislefebvre marked this pull request as ready for review March 11, 2024 12:44
@alexislefebvre alexislefebvre force-pushed the chore-remove-backup-3.x branch from 45feee5 to 826a8a6 Compare March 11, 2024 12:56
@alexislefebvre alexislefebvre force-pushed the chore-remove-backup-3.x branch from 826a8a6 to e11fb1d Compare March 11, 2024 18:20
@alexislefebvre alexislefebvre merged commit c28e599 into liip:3.x Mar 11, 2024
7 checks passed
@alexislefebvre alexislefebvre deleted the chore-remove-backup-3.x branch March 29, 2024 15:24
@jrjohnson
Copy link

@alexislefebvre removing the SqliteDatabaseBackup.php makes our tests at least 10x slower. It appeared to be working before, was it just the MySQL backup that wasn't? Would you be willing to restore this functionality (I can do the PR if needed) or is there another configuration option we should be setting to avoid needed to build the Sqlite database with every test?

@alexislefebvre
Copy link
Collaborator Author

alexislefebvre commented May 20, 2024

@jrjohnson Thanks for the feedback. Is it fixtures loading and/or the tests execution that is 10x slower?

You can revert to 2.9.0 to avoid this issue while we assess the situation.

To avoid creating the schema with every test: use the keep_database_and_schema: true option: https://github.com/liip/LiipTestFixturesBundle/blob/3.x/doc/configuration.md

@jrjohnson
Copy link

I'm not sure what is causing the slowdown, I'm just looking at a test run that has been running for almost 3 hours and is less than half way done. The only change was upgrading and removing that config. We'd generally expect all tests to run in less than an hour, for comparison this one, also from this morning took 55 minutes.

I'll try adding the keep_database_and_schema option next, but I don't want to interrupt this run until it completes so we can a full time to finish.

@jrjohnson
Copy link

Just adding a note on progress: I'm unable to get test to run at all using the keep_database_and_schema: true option. I created the database and updated it as required in the docs, but I'll need to spend some time figuring out what is missing or not working. Still interested in restoring the previous caching functionality for sure if that's an option.

@edhgoose
Copy link
Contributor

edhgoose commented Jul 1, 2024

@alexislefebvre - just to echo what @jrjohnson said: we're keen to keep this functionality, it works seamlessly for us and has done for many years. Unfortunately our repo is private so I can't share details, but happy to help where we can.

@mussbach
Copy link

mussbach commented Jul 2, 2024

same here. Glad to hear that you work on bringing back SqliteDatabaseBackup or the like. Dama is no option for us as it has problems with nested transactions

@alexislefebvre
Copy link
Collaborator Author

Backups have been reverted on an alpha release, please see here to test it and give feedback:

@alexislefebvre
Copy link
Collaborator Author

A new stable release, that support backups, has been released: https://github.com/liip/LiipTestFixturesBundle/releases/tag/3.1.0

@jrjohnson
Copy link

Thanks @alexislefebvre, we updated, looks great!

@edhgoose
Copy link
Contributor

edhgoose commented Aug 6, 2024

Ditto, thank you @alexislefebvre. We've just merged it into our prod app.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants