-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: drop support for symfony 4 #246
feat: drop support for symfony 4 #246
Conversation
Thanks for the PR, please note that the The “Symfony ^5.4 on PHP 7.4 flags” job should be green here though. |
The broken test Please rebase this PR and remove the changes in |
.github/workflows/tests.yml
Outdated
@@ -80,6 +76,10 @@ jobs: | |||
key: ${{ runner.os }}-composer-${{ matrix.php-version }}-${{ matrix.symfony-version }}-${{ hashFiles('composer.json') }} | |||
restore-keys: ${{ runner.os }}-composer-${{ matrix.php-version }}-${{ matrix.symfony-version }}- | |||
|
|||
- name: Allow Composer Plugins | |||
run: | | |||
composer config --no-plugins allow-plugins.ocramius/package-versions true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the intent of this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise i get the following error. Maybe this is only for runs on pull requests?
https://github.com/liip/LiipTestFixturesBundle/actions/runs/6841422883/job/18601768024
Symfony on PHP 7.4 flags update --prefer-lowest
ocramius/package-versions contains a Composer plugin which is blocked by your allow-plugins config. You may add it to the list if you consider it safe.
You can run "composer config --no-plugins allow-plugins.ocramius/package-versions [true|false]" to enable it (true) or disable it explicitly and suppress this exception (false)
See https://getcomposer.org/allow-plugins
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have readded this paragraph to make CI green.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to bump more dev dependencies to make ci green for --prefer-lowest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can run composer config --no-plugins allow-plugins.ocramius/package-versions true
on your branch then commit the composer.json
file. So that contributors of this bundle won't have the same error message. Then remove the change in .github/workflows/tests.yml
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes i can do this.
Some maintainers, want to have this in composer.json, and others only in the ci.
ohdearapp/health-check-results#5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
d79f4fd
to
9beec87
Compare
Thanks! |
Symfony 4.4 is EOL in the end of november. https://symfony.com/releases/4.4