-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lnd config to sideload headers. #8580
Draft
Chinwendu20
wants to merge
11
commits into
lightningnetwork:master
Choose a base branch
from
Chinwendu20:side
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2e234f7
temp change
9c00e58
lnrpc: rename file file_utils.go -> utils.go
7254fb6
lnrpc: Add new utils functions.
9a230aa
lncfg: Add new SideloadOpt to neutrino config
1b2d273
lncfg: Validate SideloadOpt and neutrino cfg
57dc6bb
lnd: Validate neutrino config build
9cf2e8f
lnd: Parse SideloadOpt for neutrino init
1984917
lntest: Add header gen for neutrino sideload test
c0e48dc
lntest: Add arg/tag for conditional sideload
dab9d34
lntest: Add check for sideload test func
a06216a
itest: Add test for neutrino sideload
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I set up this test so that it does not connect to the miner so that I can be sure that blockheaders are fed through the sideload source. The problem with that is that cfheaders would not be updated and lnd waits for the chain to be synced before starting up fully so this test would not work.
I do not know if there are any suggestions around this.
Or maybe I would continue with this when I include cfheaders sideloading in the neutrino side (which I would do after I get feedback and clarification on the latest iteration)
CC: @Roasbeef
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we want both the regular block headers and cfheaders.