mod: pull in btcsuite/btcwallet#695 #4767
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfromknecht
force-pushed
the
neutrino-rescan-locking
branch
2 times, most recently
from
2524ac9 to
1e9552d
Compare
cfromknecht
force-pushed
the
neutrino-rescan-locking
branch
from
1e9552d to
17ec653
Compare
cfromknecht
force-pushed
the
neutrino-rescan-locking
branch
from
17ec653 to
f9b577a
Compare
cfromknecht
force-pushed
the
neutrino-rescan-locking
branch
from
f9b577a to
38862ba
Compare
|
Where do we want to go from here? I think we should consider an aggressive refactoring of the existing locking logic given all the issues that've popped up over the past few years. |
Roasbeef
added
abandoned
up for grabs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in some modifications to btcwallet's locking logic for
neutrino, which prevents some lingering possible panics.
Needs to wait for btcsuite/btcwallet#695 to be merged first,
currently just seeing if this improves the state of the neutrino
itests.