loopdb: fix leapyear parsing #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhandras
reviewed
Oct 30, 2023
sputn1ck
force-pushed
the
fix_leapyear_bug
branch
from
37577e3 to
d17e024
Compare
hieblmi
reviewed
Oct 31, 2023
loopdb/sqlite.go
Outdated
| "and month %v: %v", dateTimeStr, err) | ||
| } | ||
|
|
||
| if !isLeapYear(thisYear) && isLeapYear(year) && |
There was a problem hiding this comment.
couldn't we just replace this if thisYear is not a leap year?
if !isLeapYear(thisYear) && month == 2 && day == 29 {...
There was a problem hiding this comment.
yeah seems to work as well, thanks 👍
sputn1ck
force-pushed
the
fix_leapyear_bug
branch
from
d17e024 to
b8ada04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #655 by adding a check if a date would be in a leap year.