Vec Broadcaster #3448
Vec Broadcaster #3448
Conversation
| /// is ready. | ||
| pub struct VecBroadcaster { | ||
| channel_id: ChannelId, | ||
| transactions: Mutex<Vec<Transaction>>, |
There was a problem hiding this comment.
As we'll still want to broadcast the individual packages, this might need to be a Vec<Vec<Transaction>>
There was a problem hiding this comment.
Sorry, trying to understand nomenclature, Package == Vec? If so, why do we need this? I.e. release_transactions broadcasts the whole vec of transactions, why some subsets of it need to be broadcasted separately?
| } | ||
|
|
||
| /// Used to actually broadcast stored transactions to the network. | ||
| #[instrument(skip_all, fields(channel = %self.channel_id))] |
There was a problem hiding this comment.
I'm not sure we require the instrument statment here?
There was a problem hiding this comment.
oh my bad, removed it and replaced tracing logging with ldk logger
|
|
||
| impl BroadcasterInterface for VecBroadcaster { | ||
| fn broadcast_transactions(&self, txs: &[&Transaction]) { | ||
| let mut tx_storage = self.transactions.lock(); |
There was a problem hiding this comment.
| let mut tx_storage = self.transactions.lock(); | |
| let mut tx_storage = self.transactions.lock().unwrap(); |
| fn broadcast_transactions(&self, txs: &[&Transaction]) { | ||
| let mut tx_storage = self.transactions.lock(); | ||
| for tx in txs { | ||
| tx_storage.push((*tx).to_owned()) |
There was a problem hiding this comment.
I think we might want to see if we can dedup the packages before pushing, i.e., possibly only keep the latest version of a transaction, for example if we'd bump over and over again.
There was a problem hiding this comment.
I envision this broadcaster to be used in channel monitor deserializer and I don't think it will create multiple versions of the same transaction. Do you see any other use cases?
Implementation of `BroacasterInterface` that does not broadcast transactions immediately, but stores them internally to broadcast later with a call to `release_transactions`.
yellowred
force-pushed
the
oleg_vec_broadcaster
branch
from
62671a2 to
8f3f61e
Compare
Implementation of
BroacasterInterfacethat does not broadcast transactions immediately, but stores them internally to broadcast later with a call torelease_transactions.