VLS Modifications to CLN v24.02 #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increasing the min version of the hsmd due that we added new code that required the hsmd to sign an announcements. One of the solution is to increase the min version in this way a signer like VLS fails directly during the init phase. Link: ElementsProject#7074 Changelog-None: hsmd: increase the min version Signed-off-by: Vincenzo Palazzo <[email protected]>
Signed-off-by: Vincenzo Palazzo <[email protected]>
This workflow has never had a particularly good signal-to-noise ratio, and disabling it saves us a couple of GH Actions cycles, with only minor reduction in test reach. We should rather rethink this and use the installation instructions to write Dockerfiles for each described architecture, and then have the CI test-build those Dockerfiles. That would also cover the docs during testing, rather than having yet another place where the instructions can bitrot away. Changelog-None No user-visible change.
Thanks to amazing debugging assistance from grubles, we figured out that indeed, my memory was correct: write and mmap are not consistent on all platforms. The easiest fix is to disable mmap on OpenBSD for now: the better fix is to do in-place updates using the mmap, and only rely on write() for append (which always causes a remap anyway before it's accessed). Fixes: ElementsProject#7109 Signed-off-by: Rusty Russell <[email protected]>
ksedgwic
force-pushed
the
2024-02-remote-hsmd-v24.02
branch
from
034e490 to
ed919b2
Compare
We have installation instructions that tell the user to use `poetry` and then we ourselves think we're clever and install only a known subset? It was only a matter of time until we broke this. Changelog-None
…ithub server at gitlab
Signed-off-by: Lakshya Singh <[email protected]>
Added explicit preapproveinvoice/preapprovekeysend: - tests/test_pay.py::test_setchannel_routing - tests/test_pay.py::test_forward_pad_fees_and_cltv - tests/test_pay.py::test_forward_different_fees_and_cltv - tests/test_renepay.py::test_pay - tests/test_renepay.py::test_htlc_max - tests/test_renepay.py::test_fee_allocation - tests/test_renepay.py::test_fees - tests/test_renepay.py::test_previous_sendpays SKIPPED: - tests/test_db.py::test_db_forward_migrate : no such channel - tests/test_invoices.py::test_invoices_wait_db_migration : no such channel - tests/test_reckless.py::test_poetry_install : no canned github server in gitlab CI - tests/test_reckless.py::test_install : no canned github server in gitlab CI - tests/test_reckless.py::test_tag_install : no canned github server in gitlab CI VLS_SKIP_SPLICE_TESTS: - tests/test_splicing_insane.py::test_splice_insane - tests/test_bookkeeper.py::test_bookkeeping_inspect_mfc_dual_funded VLS_PERMISSIVE: - tests/test_pay.py::test_pay_disconnect : feerate above maximum: 880782 > 151000
The problem is that the test first tries w/ a zero amount invoice and then tries to succeed w/ an explicit amount. This only works if the amount is reduced to sub-htlc levels and thus avoids the VLS balance check.
ksedgwic
force-pushed
the
2024-02-remote-hsmd-v24.02
branch
from
ed919b2 to
5b23cc5
Compare
devrandom
approved these changes
Mar 14, 2024
| @@ -960,6 +960,7 @@ def test_expiry_startup_crash(node_factory, bitcoind): | |||
| l1.start() | |||
|
|
|||
|
|
|||
| @unittest.skipIf(os.getenv('SUBDAEMON').startswith('hsmd:remote_hsmd'), "no such channel") | |||
There was a problem hiding this comment.
hmmm... does CLN change the dbid? that will break things?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge this, it's for tracking ...