Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add view prefix argument #83

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add view prefix argument #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7587f5f
Add optional view prefix to lookml view generator
sunahsuh Mar 21, 2023
4115ccd
Add `--view-prefix` cli argument
sunahsuh Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion dbt2looker/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,11 @@ def run():
help='DB Connection Name for generated model files',
type=str,
)
argparser.add_argument(
'--view-prefix',
help='Prefix to add to view names and filenames',
type=str,
)
args = argparser.parse_args()
logging.basicConfig(
level=getattr(logging, args.log_level),
Expand All @@ -118,8 +123,9 @@ def run():
adapter_type = parser.parse_adapter_type(raw_manifest)

# Generate lookml views
view_prefix = args.view_prefix or ''
lookml_views = [
generator.lookml_view_from_dbt_model(model, adapter_type)
generator.lookml_view_from_dbt_model(model, adapter_type, view_prefix)
for model in typed_dbt_models
]
pathlib.Path(os.path.join(args.output_dir, 'views')).mkdir(parents=True, exist_ok=True)
Expand Down
6 changes: 3 additions & 3 deletions dbt2looker/generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,10 +308,10 @@ def lookml_measure(measure_name: str, column: models.DbtModelColumn, measure: mo
return m


def lookml_view_from_dbt_model(model: models.DbtModel, adapter_type: models.SupportedDbtAdapters):
def lookml_view_from_dbt_model(model: models.DbtModel, adapter_type: models.SupportedDbtAdapters, view_prefix: str = ''):
lookml = {
'view': {
'name': model.name,
'name': f'{view_prefix}{model.name}',
'sql_table_name': model.relation_name,
'dimension_groups': lookml_dimension_groups_from_model(model, adapter_type),
'dimensions': lookml_dimensions_from_model(model, adapter_type),
Expand All @@ -325,7 +325,7 @@ def lookml_view_from_dbt_model(model: models.DbtModel, adapter_type: models.Supp
len(lookml['view']['dimensions']),
)
contents = lkml.dump(lookml)
filename = f'{model.name}.view.lkml'
filename = f'{view_prefix}{model.name}.view.lkml'
return models.LookViewFile(filename=filename, contents=contents)


Expand Down