Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: transforming workflow failover config #2250

Merged
merged 5 commits into from
Dec 16, 2024
Merged

fix: transforming workflow failover config #2250

merged 5 commits into from
Dec 16, 2024

Conversation

aludwiko
Copy link
Contributor

@aludwiko aludwiko commented Dec 16, 2024 •
edited
Loading

Workflow failover config is not correctly transformed from Scala SDK to Java SDK.

@github-actions github-actions bot added Documentation Improvements or additions to the documentation java-sdk-protobuf kalix-runtime Runtime and SDKs sub-team scala-sdk-protobuf labels Dec 16, 2024
patriknw
patriknw approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aludwiko aludwiko merged commit ccbb581 into main Dec 16, 2024
74 checks passed
@aludwiko aludwiko deleted the workflow-config-fix branch December 16, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patriknw patriknw patriknw approved these changes

Assignees
No one assigned
Labels
Documentation Improvements or additions to the documentation java-sdk-protobuf kalix-runtime Runtime and SDKs sub-team scala-sdk-protobuf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aludwiko @patriknw