feat: workflows support in java proto sdk #1971
Conversation
github-actions
bot
added
java-sdk
java-sdk-protobuf
kalix-runtime
| @@ -303,6 +303,8 @@ final class WorkflowImpl(system: ActorSystem, val services: Map[String, Workflow | |||
| Future.successful(toProtoEffect(effect, command.id)) | |||
|
|
|||
| case Step(executeStep) => | |||
| val context = | |||
There was a problem hiding this comment.
Context is required to call other components.
aludwiko
changed the title
|
Ready for the first round, just the codegen updates. Samples, and docs in the following PRs, because this one is big enough. |
|
One good thing to try out with the refactoring, is to build a proto sample with current latest SDK, then bump to a local version including these changes and see if things break without deleting the old generated sources (user would have their own implementation in them so not so easy to just delete-regenerate) |
There was a problem hiding this comment.
Looks good so far, one problem with the entity type change.
Except for that I think next step is to add a sample with a workflow? (Edit: saw you plan to follow up PR that, I think in general it is good to do sample together with the actual feature because you may notice problems and better to have them right in the feature PR, rather than wrong broken merged to main, but do as you prefer)
...k-protobuf/src/main/scala/kalix/scalasdk/eventsourcedentity/EventSourcedEntityProvider.scala
Show resolved
Hide resolved
I tested that, and |
aludwiko
force-pushed
the
1382-workflow-codegen-for-java
branch
from
f87346d to
b516d07
Compare
github-actions
bot
added
the
Documentation
| service.componentFullName, | ||
| throw new IllegalArgumentException( | ||
| "Service [" + service.messageType.fullyQualifiedProtoName + "] refers to entity [" + service.componentFullName + | ||
| s"], but no entity configuration is found for that component name. Entities: [${entities.keySet.mkString(", ")}]")) | ||
| "Service [" + service.messageType.fullyQualifiedProtoName + "] refers to stateful [" + service.componentFullName + |
There was a problem hiding this comment.
refers to stateful ["abc"] vs refers to component ["abc"] or refers to stateful component ["abc"]?
Also, why using both concatenation (+) and string interpolation (s) together?
There was a problem hiding this comment.
Fixed, I think that mixing was used to avoid very long line.
github-actions
bot
removed
the
Documentation
|
|
||
| s"""package $packageName; | ||
| | | ||
| |${writeImports(imports)} |
There was a problem hiding this comment.
It's pity that we didn't refactored the java codegen to use our c interpolator. Check out the scala codegen for more details.
It's much easier to use the c interpolator and then we get the imports right out of the box.
We should do some gardening in the SDK to solve this kind of issues.
There was a problem hiding this comment.
issue created #1991
* feat: workflows support in java proto sdk * deprecated since * codegen warning about deprecated usage of entity_type * warnings about depreactions from the codegen * runtime bump * codegen with all possible descriptors for workflows * updating scala samples * typo removed * improving generated integration test * using pre released version of the runtime * using pre released version of the runtime * PR comments
References