test: increase flaky test timeout #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
java-sdk-protobuf
kalix-runtime
octonato
reviewed
Nov 20, 2023
| @@ -51,7 +53,7 @@ public void createAndPublish() throws Exception { | |||
| createCustomer(customer); | |||
|
|
|||
| // wait for action to publish the change of state | |||
| var createdMsgOut = outTopic.expectOneTyped(CustomerApi.Customer.class); | |||
| var createdMsgOut = outTopic.expectOneTyped(CustomerApi.Customer.class, Duration.of(10, ChronoUnit.SECONDS)); | |||
There was a problem hiding this comment.
There is another usage of outTopic.expectOneTyped a few lines below.
I might want to also increase its timeout.
There was a problem hiding this comment.
There was a problem hiding this comment.
I assumed the flakiness come from combining the boostrapping of this on the runtime side + the delay on publishing the state, thus most likely to happen on the first call than subsequent ones.. But yeah, I would guess it can also happen in a second call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1873