Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improving eventing testkit configuration documentation #1846

Merged
merged 5 commits into from
Nov 8, 2023
Merged

docs: improving eventing testkit configuration documentation #1846

merged 5 commits into from
Nov 8, 2023

Conversation

aludwiko
Copy link
Contributor

@aludwiko aludwiko commented Nov 7, 2023

References #1845

@aludwiko aludwiko linked an issue Nov 7, 2023 that may be closed by this pull request
Improve docs for unified eventing testkit #1845
Closed
@github-actions github-actions bot added Documentation Improvements or additions to the documentation java-sdk java-sdk-protobuf kalix-runtime Runtime and SDKs sub-team scala-sdk-protobuf labels Nov 7, 2023
efgpinto
efgpinto approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@efgpinto efgpinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with small typo fix to please CI

docs/src/modules/java/pages/actions-publishing-subscribing.adoc Outdated Show resolved Hide resolved
octonato
octonato approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@octonato octonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

octonato
octonato reviewed Nov 8, 2023
View reviewed changes
samples/java-spring-eventsourced-counter/src/it/java/com/example/TestKitConfig.java Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file was renamed to contain an uppercased Kit, but there are some references still pointing to kit

@aludwiko aludwiko merged commit 9fba545 into main Nov 8, 2023
65 checks passed
@aludwiko aludwiko deleted the 1845-improve-docs-for-unified-eventing-testkit branch November 8, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octonato octonato octonato approved these changes

@efgpinto efgpinto efgpinto approved these changes

Assignees
No one assigned
Labels
Documentation Improvements or additions to the documentation java-sdk java-sdk-protobuf kalix-runtime Runtime and SDKs sub-team scala-sdk-protobuf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve docs for unified eventing testkit
3 participants
@aludwiko @octonato @efgpinto