Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto PR - Bump Proxy version to 1.1.21 #1810

Merged
merged 4 commits into from
Oct 20, 2023

Conversation

kalix-bot
Copy link
Collaborator

After proxy version reaches prod, please mark as ready, review and merge. d8b7ee235a572af5a34197ee48e5325d88146dfc

@pvlugter
Copy link
Member

Some test failures with the proxy now on H2. Looks like these are only timing issues with projections, now that they're running against a database in the usual way.

For one of the tests, looks like timing is just not waiting long enough for events to arrive.

For another, SpringSdkIntegrationTest.verifyTransformedUserViewWiring, this is creating a view for a value entity and incrementing a version counter on each update. But value entity projections are not guaranteed to get every change, so in this case it just receives the last change but with version 1. Different timing on projections again.

@pvlugter pvlugter force-pushed the bump-proxy-version-1.1.21 branch from d4bad6a to b0822d0 Compare October 19, 2023 05:40
@franciscolopezsancho
Copy link
Contributor

The test is failing it has to do with tracing. I'm looking into it.

@pvlugter
Copy link
Member

The test is failing it has to do with tracing. I'm looking into it.

Thanks. Yes, that's the remaining test that's failing now. Timed out on the docker up on one run. Increasing the timeout for traces (from 20 seconds to 1 minute) didn't help, but could still be timing.

@franciscolopezsancho
Copy link
Contributor

franciscolopezsancho commented Oct 19, 2023

So far I found in the logs that java-sdk-spring_kalix-proxy_1 exited with code 137 here, which it means that docker runs out of memory.

Which makes sense because I can't reproduce in local ATM.

@pvlugter
Copy link
Member

Ok, makes sense. Does Github Actions have resource usage metrics like in CircleCI? Could be useful to see what the difference is. Assuming the tracing test is running a bunch of things, and the proxy with H2 is pushing it over now. Can we just bump to the next size runner?

@franciscolopezsancho
Copy link
Contributor

That makes sense.
Good idea. Let me try that.

@franciscolopezsancho
Copy link
Contributor

franciscolopezsancho commented Oct 19, 2023

@franciscolopezsancho
Copy link
Contributor

I'm trying this #1814

@franciscolopezsancho
Copy link
Contributor

@franciscolopezsancho
Copy link
Contributor

Another stab at it here: #1815

@franciscolopezsancho franciscolopezsancho marked this pull request as ready for review October 20, 2023 06:31
Copy link
Contributor

@franciscolopezsancho franciscolopezsancho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proxy 1.1.21 is in prod. 100% of the services

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants