Add function to find sync frames and store avc1 codec information #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are actually 3 commits. The first fixes warnings (mainly signedness comparisons and unused stuff). The second adds
MP4D_nearest_sync_framewhich lets you find the nearest key/sync frame given any frame in the video stream. This is useful when implementing random access functionality and you want to start on a key frame. The third commit stores avc1 codec information. The WebCodecs API requires a valid codec string. To build this string you need the three bytes from theAVCDecoderConfigurationRecord. Maybe in the future we could also add a function to generate this string. :)Please let me know if this ok or I should submit separate PRs.