simplify replace system

[SergioGlorias]

not need 2 systems

Note: I noticed that fide ID placed (except 0) does not allow changing names and classification
but let's leave it like that
the important thing was the other tools non-standard events

Target: #content-dev>player name replacements

[kraktus]

Wouldn't this change break all previous broadcasts replace?

[SergioGlorias]

yes, it will break the previous Broadcasts a little...

but it also doesn't make sense to have 2 different systems (if 1 is used, it will alert broadcasters)

[SergioGlorias]

Maybe we could do what happened with the change of the old system: leave "a month" with the system running 2 systems and then delete the old one

[ornicar]

I agree the simplification is good.

Let's see if it breaks past broadcasts. These functions are called:

• during the broadcast sync
• when the broadcast form is saved

So I don't think past broadcasts would be affected, unless their form is submitted again for some other updates.
What happens then, are the players infos lost, does the form refuse to submit, ...?

[SergioGlorias]

in this case, previous broadcasts that are taking place
Without a transition period, previous transmissions stop being correct
meaning it will not replace any broadcasts
in other words: everything that was made has no adornment until it is replaced

for official broadcasts, the normal thing to do is just use player name = fide id
We rarely use the other option, except for special events when we have to replace the name