-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show or Hide broadcasts results #16650
Open
yahya-lafhal
wants to merge
37
commits into
lichess-org:master
Choose a base branch
from
yahya-lafhal:show-hide-broadcasts-results
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
af4b7b7
Add a toggle to show or hide boards results
yahya-lafhal 3754004
Show or hide results on the relayGames
yahya-lafhal c2b74c8
Add i18n for the showResults toggle and a basic translation
yahya-lafhal afc3922
Use the correct i18n
yahya-lafhal 3ccd763
Handle css for the new toggle like the others
yahya-lafhal e95b256
Fix formatting
yahya-lafhal 66caa44
Merge branch 'master' into show-hide-broadcasts-results
yahya-lafhal 195faa9
Merge branch 'master' into show-hide-broadcasts-results
ornicar b99ca77
Merge branch 'master' into show-hide-broadcasts-results
yahya-lafhal 53cdfb3
Merge branch 'master' into show-hide-broadcasts-results
ornicar a9cceb3
Merge branch 'master' into show-hide-broadcasts-results
yahya-lafhal b6624e4
Merge branch 'master' into show-hide-broadcasts-results
yahya-lafhal fb32e17
Merge remote-tracking branch 'fork/show-hide-broadcasts-results' into…
yahya-lafhal 36dc823
Merge remote-tracking branch 'upstream/master' into show-hide-broadca…
yahya-lafhal 2f764de
Remove clocks from boards grid when selecting no results
yahya-lafhal f2e3bb1
Hide eval gauges when hiding results
yahya-lafhal 6ca3a48
Make the show results toggle a stored prop
yahya-lafhal 1f92f79
Merge remote-tracking branch 'upstream/master' into show-hide-broadca…
yahya-lafhal 426fca5
Fix formatting
yahya-lafhal 861775f
Merge branch 'master' into show-hide-broadcasts-results
yahya-lafhal 6d63e0b
Merge branch 'master' into show-hide-broadcasts-results
yahya-lafhal 72e9f3f
Send to initial position when clicking on a broadcast game with resul…
yahya-lafhal 5d6027f
Fix formatting
yahya-lafhal 5507443
Merge branch 'master' into show-hide-broadcasts-results
yahya-lafhal a9cb00b
Render empty previews with a note when setting results to off
yahya-lafhal e6faf8b
Fix ts formatting
yahya-lafhal 7341cf5
Merge remote-tracking branch 'fork/show-hide-broadcasts-results' into…
yahya-lafhal 6281168
Merge branch 'master' into show-hide-broadcasts-results
yahya-lafhal 2df749b
Merge branch 'master' into show-hide-broadcasts-results
yahya-lafhal 524d7c7
Merge branch 'master' into show-hide-broadcasts-results
yahya-lafhal 84be05c
Merge branch 'master' into show-hide-broadcasts-results
ornicar 521bfff
Merge branch 'master' into show-hide-broadcasts-results
yahya-lafhal 52d13f5
Merge branch 'master' into show-hide-broadcasts-results
yahya-lafhal 5c5a09e
Merge branch 'master' into show-hide-broadcasts-results
ornicar 6fcb718
redraw immediately when switching the broadcast results toggle
ornicar ea6002a
avoid flashing the current position when hiding the current broadcast…
ornicar 79918a1
Merge branch 'master' into show-hide-broadcasts-results
yahya-lafhal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this.redraw
has been dropped? it wasn't necessary?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be working fine without it, I will test it more to make sure it's not needed.