Add interpolate #70
Merged
Add interpolate #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandlo
force-pushed
the
add-interpolate
branch
from
bb98fa1 to
5642ba2
Compare
rolandlo
force-pushed
the
add-interpolate
branch
from
5642ba2 to
b1f4202
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57
@jcupitt I renamed
Interpolate.new_from_nametoInterpolate.newin accordance withpyvipsand the namevips_interpolate_new. Or is there a point in using a different name likeInterpolate.new_from_name?By the way the test suite now runs successfully on all of 5.1, 5.2, 5.3, 5.4, luajit-2.1.0-beta3 and luajit-openresty (on Ubuntu). All versions are tested on push and pull-request.