Make sure fetch response body is read or cancelled during flush #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not reading a fetch response can block the connection, making clients require multiple connections to keep working. In environments where the number of connections are limited, clients may experience random networking errors.
gris
reviewed
Aug 14, 2024
| } | ||
|
|
||
| await resp.body?.cancel(); |
There was a problem hiding this comment.
I think we should. This will make sure exceptions are properly propagated and that things are correctly cleaned up before we move forward.
gris
approved these changes
Aug 14, 2024
haaawk
approved these changes
Aug 14, 2024
libsql-server should always return one of the two indeed. But we have many proxies along the way that might return something else in case of errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not reading a fetch response can block the connection, making clients require multiple connections to keep working. In environments where the number of connections are limited, clients may experience random networking errors.