You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
pybind11::array_t constructors don't zero their allocated memory, which can expose subtle bugs in the underlying libraries that (incorrectly) assumed that the input arrays were zeroed. To flush out these bugs, we can just modify the pybind11 code to fill the allocated arrays with some obvious nonsense:
and then check that the tests still work correctly. (Most tests involve an equality check that should fail if it encounters NaNs, or bounds checks for integers.)
MSan might also catch this but it seems tedious to get it to work with Python.
The text was updated successfully, but these errors were encountered:
pybind11::array_t
constructors don't zero their allocated memory, which can expose subtle bugs in the underlying libraries that (incorrectly) assumed that the input arrays were zeroed. To flush out these bugs, we can just modify the pybind11 code to fill the allocated arrays with some obvious nonsense:and then check that the tests still work correctly. (Most tests involve an equality check that should fail if it encounters NaNs, or bounds checks for integers.)
MSan might also catch this but it seems tedious to get it to work with Python.
The text was updated successfully, but these errors were encountered: