feat(lxlweb): Decorated suggestions (LWS-321) #1210
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tickets involved
LWS-321
Solves
Adds decorated data to supersearch suggestions in the form of a
SuggestCardcomponent, basically a slimmed version ofSearchCard. Now also fetching results for Work, Agent, Concept & Language types.As a result of new types showing up, the cards (lenses) needed adjustment. I chose a minimal approach, see examples below.
Suggestions now also probably needs relevance adjustments: a search for 'Mikael Yvesand' returns the Person as the last result.
Upgraded Svelte to be able to use the new more flexible class array syntax.
Summary of changes
SuggestionCardSearchCardgetInstanceDatafunction into utils file and add tests