Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CMake hint when searching for LibreSSL directory on macOS #1126

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

csb6
Copy link
Contributor

@csb6 csb6 commented Nov 30, 2024

The Homebrew package manager commonly used on macOS places LibreSSL in a known location, so this patch adds that directory to the search list in the CMake find script.

This makes it so macOS users do not have to directly set LIBRESSL_ROOT_DIR if they have installed it using Homebrew.

@botovq
Copy link
Contributor

botovq commented Nov 30, 2024

Thanks, I'm fine with an addition like this. I suppose people using other package managers on macOS (such as fink, pkgsrc, mac ports, nix, ...) can add their default location to the list of paths if want to have the same convenience. No need to overcomplicate this now.

@botovq botovq merged commit f843a34 into libressl:master Nov 30, 2024
47 checks passed
@vszakats
Copy link
Contributor

vszakats commented Dec 1, 2024

It could be useful to also add the new default path for ARM machines: /opt/homebrew/opt/libressl.

@csb6 csb6 deleted the cmake-homebrew branch December 1, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants