Rework RecyclerViews to set adapter once #6971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you planning on merging this PR? Because I'd rather focus on moving API and database calls to the viewmodel, so that work is performed in the right lifecycle scope. |
Yes, sure I am. However I want to merge this after the next release, because this PR also requires some deeper looking-into and testing to prevent bugs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On most pages, the recyclerview adapter is set on every refresh. By doing this, you basically loose all benefits of a recyclerview. Examples are animations and efficiency in adding items.
By refreshing the subscriptions page, the list will no longer flicker as items that are still the same will no longer be updated.
There are still one or two cases left, but the fragments they live in need some changes outside the scope of this PR before they can be fixed.