feat(LocalFeedRepository): throttle feed extraction #6949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bnyro
reviewed
Jan 13, 2025
Bnyro
reviewed
Jan 13, 2025
app/src/main/java/com/github/libretube/repo/LocalFeedRepository.kt
Outdated
Show resolved
Hide resolved
FineFindus
force-pushed
the
feat/throttle-feed-loading
branch
2 times, most recently
from
aae5579 to
8acaa16
Compare
Bnyro
reviewed
Jan 13, 2025
app/src/main/java/com/github/libretube/repo/LocalFeedRepository.kt
Outdated
Show resolved
Hide resolved
FineFindus
force-pushed
the
feat/throttle-feed-loading
branch
from
8acaa16 to
e9cb3d4
Compare
Bnyro
force-pushed
the
feat/throttle-feed-loading
branch
from
e9cb3d4 to
d614588
Compare
Throttles the local feed extration in-order to avoid rate-limiting. This is done, similary to NewPipe, by introducting an articificial delay every 50 fetched feeds of on average 1 second. These values may have to be changed in the future. Ref: libre-tube#6941 (comment)
Bnyro
force-pushed
the
feat/throttle-feed-loading
branch
from
d614588 to
4b04932
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throttles the local feed extration in-order to avoid rate-limiting. This is done, similary to NewPipe, by introducting an articificial delay every 50 fetched feeds of on average 1 second. These values may have to be changed in the future.
Ref: #6941 (comment)