Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(perf): Allow for test filtering + Github composite action #280

Merged
merged 9 commits into from
Sep 20, 2024

Conversation

maschad
Copy link
Member

@maschad maschad commented Aug 25, 2023

This PR adds a Github composite action that allows a repository to trigger the perf runner workflow for specific implementations e.g. js-libp2p only. This would facilitate running benchmarks on a release workflow for instance.

Related libp2p/js-libp2p#1964

Closes #259

@maschad
Copy link
Member Author

maschad commented Aug 29, 2023

@mxinden would you be able to trigger a test run for this?

@mxinden
Copy link
Member

mxinden commented Aug 31, 2023

Sorry for the delay here. #284 might have messed with our current setup. I am working on it.

@mxinden
Copy link
Member

mxinden commented Sep 4, 2023

master works again. Let me know once you want a review here.

@maschad
Copy link
Member Author

maschad commented Sep 4, 2023

Thanks @mxinden I think we should trigger a run first and then once that's successful, I can change it from a draft PR to be an open one.

@maschad
Copy link
Member Author

maschad commented Sep 7, 2023

@p-shahi would you be able to trigger a run for this on CI?

@p-shahi
Copy link
Member

p-shahi commented Sep 11, 2023

@maschad
Copy link
Member Author

maschad commented Sep 11, 2023

Thanks for triggering that run @p-shahi I've made some adjustments to the workflow again. Would you be able to do a re-trigger?

@maschad maschad force-pushed the feat/action-perf-benchmarks branch from 4f3d0af to 77ab89e Compare September 15, 2023 16:02
@p-shahi
Copy link
Member

p-shahi commented Sep 15, 2023

@maschad maschad marked this pull request as ready for review October 6, 2023 01:45
@maschad
Copy link
Member Author

maschad commented Oct 6, 2023

@mxinden would you be able to review this?

@dhuseby
Copy link

dhuseby commented May 7, 2024

@maschad to fix the conflict and tag @dhuseby for review

@dhuseby dhuseby self-requested a review May 7, 2024 15:45
@maschad
Copy link
Member Author

maschad commented May 7, 2024

@dhuseby I've resolved the conflicts. Thanks for reviewing this.

@dhuseby
Copy link

dhuseby commented May 14, 2024

refs libp2p/js-libp2p#2545

@dhuseby dhuseby assigned dhuseby and unassigned dhuseby May 14, 2024
@dhuseby
Copy link

dhuseby commented Jul 2, 2024

@dhuseby dhuseby merged commit ad5f4c0 into libp2p:master Sep 20, 2024
p-shahi added a commit that referenced this pull request Sep 30, 2024
@p-shahi p-shahi mentioned this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

ci: Add Github action to facilitate perf runner on select implementations
4 participants