-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(perf): Allow for test filtering + Github composite action #280
Conversation
@mxinden would you be able to trigger a test run for this? |
Sorry for the delay here. #284 might have messed with our current setup. I am working on it. |
|
Thanks @mxinden I think we should trigger a run first and then once that's successful, I can change it from a draft PR to be an open one. |
@p-shahi would you be able to trigger a run for this on CI? |
Triggered perf run https://github.com/libp2p/test-plans/actions/runs/6149594863 |
Thanks for triggering that run @p-shahi I've made some adjustments to the workflow again. Would you be able to do a re-trigger? |
4f3d0af
to
77ab89e
Compare
@mxinden would you be able to review this? |
@dhuseby I've resolved the conflicts. Thanks for reviewing this. |
@maschad when I ran this, I got this error: https://github.com/libp2p/test-plans/actions/runs/9765760822/job/26957195395#step:3:378 |
This PR adds a Github composite action that allows a repository to trigger the perf runner workflow for specific implementations e.g.
js-libp2p
only. This would facilitate running benchmarks on a release workflow for instance.Related libp2p/js-libp2p#1964
Closes #259