Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update case of arguments sent to registration.libp2p.direct #2889

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

achingbrain
Copy link
Member

At some point it became stricter about the casing of arguments so update the JSON body to golang-style sentence case instead of javascript-style camel case.

Also increase timeout for individual requests because sometimes the sever is slow.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain achingbrain requested a review from a team as a code owner December 11, 2024 18:34
At some point it became stricter about the casing of arguments so
update the JSON body to golang-style sentence case instead of
javascript-style camel case.
@achingbrain achingbrain force-pushed the fix/update-auto-tls-args branch from 80b3c61 to 04fa1e8 Compare December 11, 2024 18:35
@achingbrain achingbrain merged commit 023ea57 into libp2p:main Dec 12, 2024
33 of 34 checks passed
@achingbrain achingbrain mentioned this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant