Return None if deref encouters a broken reference (fixes #384)
#386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please give the PR and commit a more descriptive title. Please also add to end of the commit description |
br-olf
changed the title
None if deref encouters a broken reference (fixes #384)
This commit introduces a check before a referenced entry is resolved. If the referenced entry is not found `deref` will return `None`. The commit also includes a test case for this behavior. Fixes: libkeepass#384
br-olf
changed the title
None if deref encouters a broken reference (fixes #384)None if deref encouters a broken reference (fixes #384)
|
Done :) |
|
Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi I tried to fix the issue #384 and wrote a small test but I didn't mess with the test databases so I used
add_entryanddelete_entryto set up my testcase.If a reference is broken the code will now just return
Noneand won't raise an exception. I think this is better and can be caught easily by the caller ofderef.