Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if only 1 branch, display it in the list of branches #10

Merged

Conversation

Opeyem1a
Copy link
Member

@Opeyem1a Opeyem1a commented May 6, 2024

This is a suggestion, the problem outlined below can be solved in a number of ways.

In the hop command, we filter out the current branch from the list of branches shown to select
If there is only 1 branch, and you are on that branch, this means the UI renders nothing and it looks like the command is stalling.

This PR renders the only branch if there is only 1

@Opeyem1a
Copy link
Member Author

Opeyem1a commented May 6, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Opeyem1a and the rest of your teammates on Graphite Graphite

@Opeyem1a Opeyem1a requested review from aadiraju and MtheDV May 6, 2024 07:47
src/commands/hop.tsx Outdated Show resolved Hide resolved
@Opeyem1a Opeyem1a force-pushed the 05-06-if_only_1_branch_display_it_in_the_list_of_branches branch from 31d9217 to c46a280 Compare May 7, 2024 03:59
@Opeyem1a Opeyem1a requested a review from MtheDV May 7, 2024 04:04
aadiraju
aadiraju previously approved these changes May 7, 2024
@Opeyem1a Opeyem1a merged commit 31b7a2c into main May 7, 2024
2 checks passed
@Opeyem1a Opeyem1a deleted the 05-06-if_only_1_branch_display_it_in_the_list_of_branches branch May 7, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants