Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Author page removal #152

Merged
merged 7 commits into from
May 13, 2024
Merged

Author page removal #152

merged 7 commits into from
May 13, 2024

Conversation

perfect10-vst
Copy link
Contributor

No description provided.

Copy link
Member

@srishti-nema srishti-nema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove the respective details from _config.yml file as well?

@perfect10-vst
Copy link
Contributor Author

Can you please remove the respective details from _config.yml file as well?

Removed

Copy link
Member

@srishti-nema srishti-nema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for now, opened #153 to fix build check issues later. Though, I think the changes won't get deployed without the build checks passing...

@srishti-nema srishti-nema merged commit ea81018 into leomvit:master May 13, 2024
0 of 4 checks passed
@srishti-nema
Copy link
Member

Approving for now, opened #153 to fix build check issues later. Though, I think the changes won't get deployed without the build checks passing...

Looks like merging to main deploys the changes since it is a static site... I don't think there is a separate deployment mechanism, just some checks and a test preview enabled via Netlify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants