Code improvements and fixes #72

donosonaumczuk · 2025-01-09T16:52:57Z

No description provided.

…ot length check

height · 2025-01-09T16:53:00Z

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

…r custom errors

…t-viair Merge `Code changes` with `Compile without viair`

…isting usernames

…ms when processing params not present

…semantics

…) and 1 instad of address(0) and 0, to avoid reverting with invalid param

…sControl

donosonaumczuk added 2 commits January 7, 2025 17:31

misc: TODO solved - isImmutable storage replaced by _contentURISnapsh…

20139fd

…ot length check

fix: Missing rule selector validation on primitives added

8eab952

donosonaumczuk and others added 27 commits January 9, 2025 15:23

misc: compiler bump to 0.8.28 - pragma bump to ^0.8.26 - preparing fo…

6f7274f

…r custom errors

misc: Custom Errors added on every revert case

f3e80a0

misc: add fuzzing, via_ir and zkSync compilation to foundry.toml

f4f8751

misc: commented out all lines that caused stack-too-deep

f435b95

misc: Namespaces and Graph compile without IR

5873156

misc: Rule Based Feed and Group made to compile without IR

706a0aa

misc: RuleBasePrimitive made to compile without IR

0ba5dd1

misc: Feed made to compile without IR

c5a740a

misc: MigrationFeed made to compile without IR

af083d7

misc: LensFactory made to compile without IR

0aad9f2

misc: LensFactory tests made to compile without IR

cc4fe7e

Merge pull request #73 from lens-protocol/code-changes-compile-withou…

a157a84

…t-viair Merge `Code changes` with `Compile without viair`

misc: Namespace code updated to give better revert reasons for non-ex…

cef1882

…isting usernames

test: coverage skipper added to deploy script

8198261

test: coverage scripts added

e6ed308

misc: added checks for address(0) to GraphCore

0da8a99

fix: MigrationGraph fixed

20e2200

fix: MigrationFeed extradata saving fix

283d303

misc: Better error throwing during enable/disable rule selectors

f4b42d5

misc: SkipTokenGate refactored to a more generic SkipGate permission

738c509

fix: Added missing _processEntityRulesChanges override on Feed and Graph

dfd8e4b

misc: getUsernameTokenId modifier from view to pure

a936313

misc: add TippingPostAction to deployment script

df046e9

fix: Post Rules events emitters added

fdbd1c7

fix: Follow Rules events emitters added

1a5ce2a

fix: editPost fixed (core call missing)

dd7919c

misc: MigrationFeed changed to have forceChecks always

b862efd

donosonaumczuk and others added 11 commits January 16, 2025 15:47

fix: Rule processing main for-loop logic fixed - Call with empty para…

404b461

…ms when processing params not present

misc: bool return from call renamed to callSucceeded for better code …

3984082

…semantics

misc: IAccessControl incomplete natspec comment completed

036baf8

fix: Access Control verification function now calls with address(this…

a7dce24

…) and 1 instad of address(0) and 0, to avoid reverting with invalid param

misc: Diff error constants and validations moved up on RoleBasedAcces…

3ce2ff1

…sControl

misc: proxy__ prefix added to BeaconProxy functions

b1652f7

fix: make all the rule-related hooks abstract and required to override

95176ad

feat: handledcall and handledsafecall added to CallLib

7395e05

fix: properly retrieve selector from ProxyAdmin call's calldata

a0bb896

fix: Use handled flavour for safecall and call when needed

96c48f6

misc: processRemovePost renamed to processDeletePost

f458e57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Code improvements and fixes #72

Code improvements and fixes #72

donosonaumczuk commented Jan 9, 2025

height bot commented Jan 9, 2025

Code improvements and fixes #72

Are you sure you want to change the base?

Code improvements and fixes #72

Conversation

donosonaumczuk commented Jan 9, 2025

height bot commented Jan 9, 2025