Use custom overlap check instead of the one from G4GDML #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ManuelHu
commented
May 1, 2024
ManuelHu
commented
- call overlap check after reading all GDML files
- reduce verbosity of overlap check; do not show lines of succeeded checks
- also increase the number of points in overlap check, increasing from the default of 1000 to 3000
- this now catches overlaps that were not previously reported...
* call overlap check after reading all GDML files * reduce verbosity of overlap check; do not show lines of _succeeded_ checks * also increase the number of points in overlap check, increasing from the default of 1000 to 3000 * this now catches overlaps that were not previously reported...
ManuelHu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.