Misc fixes #67
Merged
Misc fixes #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this mutates a vector while it is iterated, which is potentially unsafe. Anyway, one can just use /control/execute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RMGToolsfor handling of string/enums, so removing some usages of fmt/magic_enum/RMG/Manager/Includemodifies the vector of macro files while it is being iterated. This is potentially unsafe (it might invalidate the iterator).Moreover, I think this command is rather useless: One can just use
/control/executeinstead. The command also did never work in interactive mode._RMG_*constants in the header files where not aligned with the file names anymore (after a lot of renames)G4State_PreInit; their value is just used once in the physics list setup. Changing it afterwards will not work.